remove leftover debug code: console.log() calls #796
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
After upgrading to 2.2.1, I realized my console was polluted by what appears to be leftover debug code:
I commented out the culprit lines. Also removed some whitespace and added a spacing after an if.
My recommendations:
console.err()
orconsole.warn()
when you wish to log an error or a warningconsole
but have a generic function such aslog(level, msg)
where you provide a level (debug, notice, warn, err) and the wrapper will only emit a message in the console if the loglevel is below the message level. So in dev you'll have your loglevel to "show me everything", and in prod it will just show the warn and errors. This will allow you to leave the debug lines in your code instead of having to comment them out, which is prone to errors.console.log()
calls are present (https://eslint.org/docs/latest/rules/no-console)Best,
~Nicolas