Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor remaining files in parser/utils #761

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

prajwalkulkarni
Copy link
Contributor

💫 Changelog

⭐ Improved typesafety in the remaining TS files located in parser/utils.
⭐ Changed var to let and const as applicable.
⭐ Added strict equality check
⭐ If the name of identifiers of key and value are the same, do not pass the value identifier explicitly. E.g: Instead of using atoms.push({x:x,y:y}) simply use atoms.push({x,y})

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (8c3e9d4) 82.62% compared to head (ca7ecbd) 82.59%.

Files Patch % Lines
src/parsers/utils/getSinglePDB.ts 95.34% 1 Missing and 1 partial ⚠️
src/parsers/utils/assignPDBBonds.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #761      +/-   ##
==========================================
- Coverage   82.62%   82.59%   -0.03%     
==========================================
  Files         141      141              
  Lines       11496    11495       -1     
  Branches     2126     2126              
==========================================
- Hits         9498     9494       -4     
- Misses       1667     1670       +3     
  Partials      331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dkoes dkoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dkoes dkoes merged commit 6f0a345 into 3dmol:master Jan 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants