Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed Unused Variables #712

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

adithyaakrishna
Copy link
Contributor

Description:

  • Removed unused variables and added // @ts-ignore for needed ones

Signed-off-by: Adithya Krishna <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #712 (85cc0fd) into master (3639feb) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   83.06%   83.06%   -0.01%     
==========================================
  Files         141      141              
  Lines       11458    11435      -23     
  Branches     2114     2112       -2     
==========================================
- Hits         9518     9498      -20     
+ Misses       1609     1606       -3     
  Partials      331      331              
Files Changed Coverage Δ
src/GLShape.ts 89.25% <ø> (ø)
src/Label.ts 90.56% <ø> (ø)
src/WebGL/Camera.ts 88.00% <ø> (ø)
src/WebGL/Renderer.ts 83.15% <ø> (-0.16%) ⬇️
src/WebGL/core/Geometry.ts 74.90% <ø> (ø)
src/colors.ts 90.90% <ø> (ø)
src/parsers/MMTF.ts 97.35% <ø> (-0.17%) ⬇️
src/parsers/utils/getSinglePDB.ts 94.32% <ø> (-0.20%) ⬇️

... and 1 file with indirect coverage changes

@adithyaakrishna
Copy link
Contributor Author

Thanks, @codecov bot, you da best!

Copy link
Contributor

@dkoes dkoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ts-ignores need to be well justified.

src/WebGL/Renderer.ts Outdated Show resolved Hide resolved
Adithya Krishna added 2 commits August 29, 2023 19:14
Signed-off-by: Adithya Krishna <[email protected]>
- v2

Signed-off-by: Adithya Krishna <[email protected]>
@dkoes dkoes merged commit 1d2f8cc into 3dmol:master Aug 29, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants