Updated Types for Parsers and Parser Utils #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2023 19:36
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
|
Parser Utils is giving a type error, will fix it first thing tomorrow morning :) |
added 6 commits
July 12, 2023 14:35
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Signed-off-by: Adithya Krishna <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 83.01% 83.06% +0.05%
==========================================
Files 141 141
Lines 11450 11457 +7
Branches 2112 2114 +2
==========================================
+ Hits 9505 9517 +12
+ Misses 1613 1609 -4
+ Partials 332 331 -1
|
|
@dkoes Tests Passed 🎉 |
dkoes
requested changes
Jul 13, 2023
|
@dkoes My bad, Thank you for pointing them out :) |
Signed-off-by: Adithya Krishna <[email protected]>
adithyaakrishna
force-pushed
the
feat/types-parsers
branch
from
7f849eb
to
bd4c2d2
Compare
dkoes
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the types for Parsers and its utility functions