Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - Updated Sessions.js #690

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Conversation

adithyaakrishna
Copy link
Contributor

Description:

  • Used Array.from() instead of .push()

Signed-off-by: Adithya Krishna <[email protected]>
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #690 (2c53e4a) into master (2852865) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #690      +/-   ##
==========================================
+ Coverage   82.83%   83.01%   +0.17%     
==========================================
  Files         141      141              
  Lines       11450    11450              
  Branches     2112     2112              
==========================================
+ Hits         9485     9505      +20     
+ Misses       1633     1613      -20     
  Partials      332      332              

see 2 files with indirect coverage changes

@adithyaakrishna
Copy link
Contributor Author

@dkoes Could you pls lmk if these changes looks good?

learning-environment/sessions.js Outdated Show resolved Hide resolved
learning-environment/sessions.js Outdated Show resolved Hide resolved
Signed-off-by: Adithya Krishna <[email protected]>
learning-environment/sessions.js Outdated Show resolved Hide resolved
Signed-off-by: Adithya Krishna <[email protected]>
@dkoes dkoes merged commit de25047 into 3dmol:master Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants