-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/cli #572
base: alpha-dev
Are you sure you want to change the base?
Feat/cli #572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I added two remarks. Once you have addressed these, I would take over and remove the C++ CLI part that is not used anymore. That should also make coverage testing happy.
Only prints arguments and help so far.
util imports numpy, which conflicts with util and platform. Renaming to utils and platforms.
f2166f3
to
56fa1e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the old CLI. Apart from one question, this is ready to merge from my side.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## alpha-dev #572 +/- ##
=============================================
+ Coverage 55.88% 58.68% +2.80%
=============================================
Files 475 471 -4
Lines 20170 19947 -223
Branches 1664 1627 -37
=============================================
+ Hits 11271 11706 +435
+ Misses 8899 8241 -658 ☔ View full report in Codecov by Sentry. |
c0cf094
to
30373a7
Compare
fixes #529
Implementation of a cli using click.
Following options are currently without function:
Renamed util to utils and platform to platforms due to import conflict with numpy, which has the same filenames.