Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cli #572

Open
wants to merge 22 commits into
base: alpha-dev
Choose a base branch
from
Open

Conversation

KRiedmiller
Copy link

@KRiedmiller KRiedmiller commented Feb 25, 2025

fixes #529

Implementation of a cli using click.

Following options are currently without function:

  • disableLegNoise
  • disablePlatformNoise
  • noSceneWriting
  • rebuildScene
  • fixedIncidenceAngle
  • calcEchowidth
  • zipOutput
  • las10
  • fullwaveNoise

Renamed util to utils and platform to platforms due to import conflict with numpy, which has the same filenames.

Copy link
Collaborator

@dokempf dokempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I added two remarks. Once you have addressed these, I would take over and remove the C++ CLI part that is not used anymore. That should also make coverage testing happy.

Copy link
Collaborator

@dokempf dokempf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the old CLI. Apart from one question, this is ready to merge from my side.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 90.19608% with 10 lines in your changes missing coverage. Please review.

Project coverage is 58.68%. Comparing base (e54e712) to head (4ca7710).

Files with missing lines Patch % Lines
python/helios/__main__.py 89.01% 10 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           alpha-dev     #572      +/-   ##
=============================================
+ Coverage      55.88%   58.68%   +2.80%     
=============================================
  Files            475      471       -4     
  Lines          20170    19947     -223     
  Branches        1664     1627      -37     
=============================================
+ Hits           11271    11706     +435     
+ Misses          8899     8241     -658     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dokempf dokempf force-pushed the feat/cli branch 2 times, most recently from c0cf094 to 30373a7 Compare March 4, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants