-
Notifications
You must be signed in to change notification settings - Fork 17
Take \tikzpicture out of karnaugh-map environment (fixes #21) #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myzhang1029
wants to merge
13
commits into
2pi:master
Choose a base branch
from
myzhang1029:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
65d9962
take \tikzpicture out of karnaugh-map environment
myzhang1029 30e367f
Remove the now-unneeded group and add test
myzhang1029 1092faf
Convert omittikzpicture to an option
myzhang1029 2217120
Add test for the global option
myzhang1029 b3afd81
Reorder options
myzhang1029 fb83f34
Add documentation for omittikzpicture
myzhang1029 a6107f8
Update docs per suggestion
myzhang1029 d47563b
Use scoping
myzhang1029 ce5ad0d
Move scope to main environment
myzhang1029 2fa9c6a
Code-only example for omittikzpicture
myzhang1029 a1ac416
Implement option testing (hack)
myzhang1029 826da27
Swap misnamed test files
myzhang1029 8ba81d6
Allow local overrides to global bool options
myzhang1029 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| karnaugh-option-omit-tikzpicture-default.pdf |
Binary file not shown.
17 changes: 17 additions & 0 deletions
17
test/karnaugh-221-label-omit-tikzpicture-global-option.tex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| \documentclass{standalone} | ||
| \usepackage[omittikzpicture]{../karnaugh-map} | ||
| \begin{document} | ||
| % v1/v2 label | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}[2][2][1] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}[2][2][1][$a$] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}[2][2][1][$a$][$b$] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \end{document} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| \documentclass{standalone} | ||
| \usepackage{../karnaugh-map} | ||
| \begin{document} | ||
| % v1/v2 label | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1][$a$] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1][$a$][$b$] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \end{document} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| \documentclass{standalone} | ||
| \usepackage[omittikzpicture]{../karnaugh-map} | ||
| \begin{document} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}[4][4][1] | ||
| \implicant{0}{0} | ||
| \implicant{1}{1} | ||
| \implicant{2}{2} | ||
| \implicant{3}{3} | ||
| \implicant{4}{4} | ||
| \implicant{5}{5} | ||
| \implicant{6}{6} | ||
| \implicant{7}{7} | ||
| \implicant{8}{8} | ||
| \implicant{9}{9} | ||
| \implicant{10}{10} | ||
| \implicant{11}{11} | ||
| \implicant{12}{12} | ||
| \implicant{13}{13} | ||
| \implicant{14}{14} | ||
| \implicant{15}{15} | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture=false)[4][4][1] | ||
| \implicant{0}{0} | ||
| \implicant{1}{1} | ||
| \implicant{2}{2} | ||
| \implicant{3}{3} | ||
| \implicant{4}{4} | ||
| \implicant{5}{5} | ||
| \implicant{6}{6} | ||
| \implicant{7}{7} | ||
| \implicant{8}{8} | ||
| \implicant{9}{9} | ||
| \implicant{10}{10} | ||
| \implicant{11}{11} | ||
| \implicant{12}{12} | ||
| \implicant{13}{13} | ||
| \implicant{14}{14} | ||
| \implicant{15}{15} | ||
| \end{karnaugh-map} | ||
| \end{document} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| \documentclass{standalone} | ||
| \usepackage{../karnaugh-map} | ||
| \begin{document} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][1] | ||
| \implicant{0}{0} | ||
| \implicant{1}{1} | ||
| \implicant{2}{2} | ||
| \implicant{3}{3} | ||
| \implicant{4}{4} | ||
| \implicant{5}{5} | ||
| \implicant{6}{6} | ||
| \implicant{7}{7} | ||
| \implicant{8}{8} | ||
| \implicant{9}{9} | ||
| \implicant{10}{10} | ||
| \implicant{11}{11} | ||
| \implicant{12}{12} | ||
| \implicant{13}{13} | ||
| \implicant{14}{14} | ||
| \implicant{15}{15} | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{karnaugh-map}[4][4][1] | ||
| \implicant{0}{0} | ||
| \implicant{1}{1} | ||
| \implicant{2}{2} | ||
| \implicant{3}{3} | ||
| \implicant{4}{4} | ||
| \implicant{5}{5} | ||
| \implicant{6}{6} | ||
| \implicant{7}{7} | ||
| \implicant{8}{8} | ||
| \implicant{9}{9} | ||
| \implicant{10}{10} | ||
| \implicant{11}{11} | ||
| \implicant{12}{12} | ||
| \implicant{13}{13} | ||
| \implicant{14}{14} | ||
| \implicant{15}{15} | ||
| \end{karnaugh-map} | ||
| \end{document} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| \documentclass{standalone} | ||
| \usepackage{../karnaugh-map} | ||
| \begin{document} | ||
| % fill all fields (autoterms) | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][4][1] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][2][1] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][1] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][2] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][4] | ||
| \autoterms[-] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| % fill remaining after '\indeterminants' '\manualterms' '\maxterms' and '\minterms' | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1] | ||
| \manualterms{m} | ||
| \indeterminants{1} | ||
| \maxterms{2} | ||
| \minterms{3} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][2][1] | ||
| \manualterms{m} | ||
| \terms{1}{T} | ||
| \indeterminants{1} | ||
| \maxterms{2} | ||
| \minterms{3} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[2][4][1] | ||
| \manualterms{m} | ||
| \indeterminants{1} | ||
| \maxterms{2} | ||
| \minterms{3} | ||
| \terms{4}{T} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][2][1] | ||
| \manualterms{m} | ||
| \indeterminants{1} | ||
| \maxterms{2} | ||
| \minterms{3} | ||
| \terms{4}{T} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][1] | ||
| \manualterms{m,m} | ||
| \indeterminants{2,3} | ||
| \maxterms{4,5} | ||
| \minterms{6,7} | ||
| \terms{8,9}{T} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][2] | ||
| \manualterms{m,m,m,m} | ||
| \indeterminants{4,5,6,7} | ||
| \maxterms{8,9,10,11} | ||
| \minterms{12,13,14,15} | ||
| \terms{16,17,18,19}{T} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \begin{tikzpicture} | ||
| \begin{karnaugh-map}(omittikzpicture)[4][4][4] | ||
| \manualterms{m,m,m,m} | ||
| \indeterminants{4,5,6,7} | ||
| \maxterms{8,9,10,11} | ||
| \minterms{12,13,14,15} | ||
| \terms{16,17,18,19}{T} | ||
| \autoterms[a] | ||
| \end{karnaugh-map} | ||
| \end{tikzpicture} | ||
| \end{document} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.