Skip to content

fix(tracing): remove unused imports#40

Closed
skot wants to merge 1 commit into256foundation:mainfrom
skot:macos-warnings-fix
Closed

fix(tracing): remove unused imports#40
skot wants to merge 1 commit into256foundation:mainfrom
skot:macos-warnings-fix

Conversation

@skot
Copy link
Collaborator

@skot skot commented Mar 7, 2026

Summary

  • make Linux-only tracing imports conditional
  • remove the unused local tracing prelude import
  • keep the journald fallback log message via a fully qualified macro

Validation

  • cargo test --no-run

@skot
Copy link
Collaborator Author

skot commented Mar 7, 2026

this PR is to support building mujina on macos without warnings.

@skot
Copy link
Collaborator Author

skot commented Mar 10, 2026

there is some overlap here with #32

@rkuester
Copy link
Collaborator

Thanks for filing. I took the issues raised here, along with the overlap in #32, as a hint that conditional compilation of the journald features required a bit of a refactoring to consolidate the #[cfg]s multiplying throughout the file. See 3176b56.

@rkuester rkuester closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants