Open
Conversation
|
Hey @jbride, good job with the pull request mate! I wish GitHub would allow me to submit a proper review, so I'll do it with comments for now. Found an issue with the CPU miner config: I asked my LLM to provide a fix and then it provided this solution, maybe you want to port it to your branch. |
|
Another improvement would be replacing or removing references to the old environment variables. Found instances on the following files:
Some of the mentions are in the context of explaining this PR's changes but some are just residue, if left like that it might confuse and misinform future developers. |
|
nit: Maybe we should find ways to avoid committing real config files by accident and leaking secrets? For one we could add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details of implementation can be found here.