feat(usb): set bcdDevice to v5.0.0 for hardware revision 5#15
Merged
skot merged 1 commit into256foundation:mainfrom Mar 20, 2026
Merged
feat(usb): set bcdDevice to v5.0.0 for hardware revision 5#15skot merged 1 commit into256foundation:mainfrom
skot merged 1 commit into256foundation:mainfrom
Conversation
Use BCD version format where major indicates hardware revision and minor.patch indicates firmware version. Firmware versioning restarts with each hardware revision. This allows Mujina to distinguish v4, v5, and future hardware revisions.
korbin
approved these changes
Jan 22, 2026
Contributor
Author
|
@skot Would you please review and merge this? Also, perhaps we merge/rebase the |
Contributor
Author
Contributor
Author
|
@skot Any objections to this one? I'd like to make another change that depends on this being merged. |
Collaborator
|
LGTM. merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use BCD version format where major indicates hardware revision and
minor.patch indicates firmware version. Firmware versioning restarts
with each hardware revision.
This allows Mujina to distinguish v4, v5, and future hardware revisions.