feat(antminer): support stock firmware pool configuration#185
Merged
b-rowan merged 8 commits into256foundation:masterfrom Mar 19, 2026
Merged
Conversation
cfilipescu
force-pushed
the
feat/antminer-pool-config-from-dan-master
branch
from
bf877b3 to
d60eb89
Compare
b-rowan
requested changes
Mar 18, 2026
Member
|
Main issue here is that the parsing for |
b-rowan
requested changes
Mar 19, 2026
Stock Bitmain firmware stores pool configuration in get_miner_conf.cgi endpoint, which persists even when miners are idle. The RPC 'pools' command only returns runtime status and can be empty when pools haven't connected yet. This change queries both endpoints and falls back to the configuration when RPC returns no pools, ensuring pool migration works reliably during firmware installation.
Add password field to PoolData struct and parse the 'pass' key from get_miner_conf.cgi when falling back to configuration-based pool detection. All other backends set password to None as they read from runtime RPC status which does not expose passwords.
cfilipescu
force-pushed
the
feat/antminer-pool-config-from-dan-master
branch
from
e919b44 to
f00428e
Compare
b-rowan
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupportsPoolsConfig::set_pools_configValidation