Repository navigation
Backend/room model - #17
Merged
Merged
Conversation
that was causing build failure
Formatting Issues Detected!
View Csharpier output |
Formatting Issues Detected!
View Csharpier output |
Salvarez99
approved these changes
Oct 15, 2025
alt-potato
requested changes
Oct 15, 2025
alt-potato
left a comment
Collaborator
There was a problem hiding this comment.
Some notes about GameState, plus that formatting warning. Otherwise, looks good.
| [MaxLength(50)] | ||
| public required string GameMode { get; set; } | ||
|
|
||
| [MaxLength(50)] |
Collaborator
There was a problem hiding this comment.
Suggested change
| [MaxLength(50)] |
Since GameState is a json string, 50 characters is not nearly enough. SQL Server also has a dedicated JSON column type, which would probably be better here. Might need Fluent API for that, instead of just annotations.
Formatting Issues Detected!
View Csharpier output |
Salvarez99
approved these changes
Oct 16, 2025
Kush12747
approved these changes
Oct 16, 2025
alt-potato
approved these changes
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Room model