Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/iss 240 bin packaging #92

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

shide1989
Copy link
Contributor

@shide1989 shide1989 commented Jan 8, 2025

🚀 Pull Request Overview

What does this PR do? 🤔

This PR adds the capability of building the CLI into a single binary package.

Although it is a first working version, we will need to change the approach since the library used is now deprecated and compiles for Node <= v18.

Also since Node > v18.16 now has the Single executable Application feature, we should use this approach instead @zhuk-aa

  • This feature allows the distribution of a Node.js application conveniently to a system that does not have Node.js installed

Related Issues 📝

💻 Changes Summary

  • Change 1: Added the NPM package script to compile the build for MacOS
  • Change 2: Added the build target node18-macos-arm64

✅ Checklist

  • I have built and run the binary for MacOS Arm64, and verified that the @2501 cli works well.

📈 Impact Analysis

  • Limitations: This first version will not be sustainable in the long run as mentioned previously

@shide1989 shide1989 self-assigned this Jan 8, 2025
"package.json"
],
"targets": [
"node18-macos-arm64"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add node18-linux too ? and a windows version ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now we stick with MacOS (following our discussions with Alex Z)

@zhuk-aa zhuk-aa changed the title Feature/iss 240 bin packaging WIP: Feature/iss 240 bin packaging Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants