Feature/iss 198 sub process #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shide1989
commented
Dec 11, 2024
| @@ -134,3 +149,49 @@ export async function browse_url(args: { url: string }) { | |||
| ${md.replace(/\s+/g, '')} | |||
| `; | |||
| } | |||
|
|
|||
| export async function check_process_status( | |||
There was a problem hiding this comment.
For now this check_process_status function is unused, I'm thinking about keeping it or not since it can help the agent to retrieve the info faster 🤔
shide1989
commented
Dec 11, 2024
| .split('\n') | ||
| .find((line) => line.includes(`export UNIQUE_PROCESS_ID=${uniqueID}`)); | ||
| if (!line) { | ||
| throw new Error('Child process not found'); |
There was a problem hiding this comment.
not sure we should throw an error, or simply return a shellProcess with a 'terminated' status, to inform that the process has been terminated.
There was a problem hiding this comment.
I think for now I would rather have the CLI send an error in some edge cases, than having a silent error and having to dig the code to find why some shellprocesses would be terminated unexpectedly
BonnardValentin
approved these changes
Dec 16, 2024
|
must be tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request Overview
What does this PR do? 🤔
This PR allows an AI agent to start and check the status and logs of a background process.
For ex, you can start a docker build, and check the status a few minutes later, the agent will have all the info (Process ID, Logs etc.)
Related Issues 📝
💻 Changes Summary
syncargument for the run_shell command. This way AI Agents less tend to create commands that run in the background by themselves. See Engine for more details..2501/logsdirectory. This might be subject to change✅ Checklist
📈 Impact Analysis