Add Rust fping implementation as optional dependency-free alternative #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation provides better performance and eliminates the need for the system fping package while maintaining full compatibility with existing configurations. Key features: - Drop-in replacement with automatic fallback to system fping - Same output format and interface as original fping - No external dependencies when Rust extension is built - Complete test coverage and example configuration - Build script for easy compilation The implementation uses system ping commands internally to avoid raw socket permission requirements while still providing a native Rust experience.
grizz
approved these changes
Aug 15, 2025
Implements a comprehensive fping-compatible CLI interface that provides a drop-in replacement for the traditional fping utility using vaping's high-performance Rust implementation. Key features: - Full fping command-line compatibility with all major options - Real-time verbose count mode with cumulative statistics - Proper timeout handling (1 second default) - Exit code compatibility with original fping - Comprehensive test suite with 25+ test cases - Complete documentation with examples Files added: - src/vaping/fping_cli.py - Main CLI implementation - tests/test_fping_cli.py - Comprehensive test suite - docs/fping-cli.md - User documentation Files modified: - src/lib.rs - Enhanced Rust implementation with timeout parameter - src/vaping/cli.py - Integration as vaping subcommand - README.md - Updated with fping command documentation - mkdocs.yml - Added documentation to navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation provides better performance and eliminates the need for the system fping package while maintaining full compatibility with existing configurations.
Key features:
The implementation uses system ping commands internally to avoid raw socket permission requirements while still providing a native Rust experience.