-
Notifications
You must be signed in to change notification settings - Fork 0
[feat] 코스 테스트 코드 작성 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough테스트 의존성 AssertJ를 추가하고, 엔티티 생성자/세터의 가시성을 확장했으며, 코스 도메인에 대한 통합 테스트를 신규 추가했습니다. 공개 API(메서드 시그니처) 변경은 엔티티 생성자 및 User 세터 추가에 한정됩니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant T as CourseServiceTest
participant S as CourseService
participant R1 as CourseRepository
participant R2 as CourseComponentRepository
rect rgba(200,230,255,0.3)
note right of T: 추천 코스 조회
T->>S: recommendCourses(lat, lon, timeWindow, place)
S->>R1: find/retrieve candidates
R1-->>S: courses
S-->>T: List<CourseResponse>
end
rect rgba(220,255,220,0.3)
note right of T: 코스 좋아요
T->>S: likeCourse(userId, courseId)
S->>R1: save/like
R1-->>S: updated state
S-->>T: LikeResponse
end
rect rgba(255,240,200,0.3)
note right of T: 코스 상세 조회
T->>S: fetchCourseDetail(courseId)
S->>R1: findById(courseId)
R1-->>S: Course
S->>R2: findComponents(courseId)
R2-->>S: components
S-->>T: CourseDetailResponse
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📌 PR 개요
✅ 변경사항
🔍 체크리스트
📎 관련 이슈
Closes #98
💬 기타 참고사항
Summary by CodeRabbit