Skip to content

Conversation

@kamillcream
Copy link
Contributor

@kamillcream kamillcream commented Sep 16, 2025

📌 PR 개요

  • 관광지 상세 정보 Dto에 색상 정보 추가

✅ 변경사항

  • TourSpotTag에 tagColor 추가 후 응답 객체에 포함.

🔍 체크리스트

  • PR 제목은 명확한가요?
  • 관련 이슈가 있다면 연결했나요?
  • 로컬 테스트는 통과했나요?
  • 코드에 불필요한 부분은 없나요?

📎 관련 이슈

Closes #91


💬 기타 참고사항

Summary by CodeRabbit

  • 신기능

    • 관광지 태그에 색상 정보가 추가되었습니다. 목록/상세/검색 결과 등에서 태그가 색상으로 구분되어 가독성과 식별성이 향상됩니다.
  • 개선

    • 태그 데이터 구조가 확장되어 향후 UI 전반에서 일관된 색상 표시를 지원합니다.
  • 정리

    • 사용되지 않는 코드를 정리했습니다. 성능이나 기존 기능에는 영향이 없습니다.

@kamillcream kamillcream linked an issue Sep 16, 2025 that may be closed by this pull request
1 task
@coderabbitai
Copy link

coderabbitai bot commented Sep 16, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

관광지 태그에 색상을 표현하기 위해 tagColor 속성이 엔티티와 DTO에 추가되었고, 매퍼 파일에서 불필요한 import 두 건이 제거되었습니다.

Changes

Cohort / File(s) Summary
TourSpotTag 색상 필드 추가
src/main/java/com/opendata/domain/tourspot/dto/TourSpotTagDto.java, src/main/java/com/opendata/domain/tourspot/entity/TourSpotTag.java
DTO 레코드 시그니처에 tagColor 추가(생성자 및 tagColor() 접근자 생성). 엔티티에 @Column(name = "tag_color") private String tagColor; 필드 추가.
매퍼 정리
src/main/java/com/opendata/domain/tourspot/mapper/TourSpotDetailMapper.java
미사용 import 2건 제거. 기능/공개 API 변경 없음.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant C as Client
  participant S as API Server
  participant SR as Service
  participant R as Repository
  participant DB as Database

  C->>S: GET /tour-spots/{id}/tags
  S->>SR: findTagsByTourSpot(id)
  SR->>R: query tags with color
  R->>DB: SELECT ... tag_color ...
  DB-->>R: rows (category, tag_color)
  R-->>SR: List<TourSpotTag>
  SR->>S: Map to TourSpotTagDto(category, tagColor)
  S-->>C: 200 OK (DTOs with tagColor)
  
  note over S,SR: tagColor 필드 포함 매핑/전달
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

꼬박꼬박 태그에 빛을 입혀, 반짝!
토끼는 팔레트를 흔들며 깡총 깡총 착!
카테고리 옆에 색 한 줄, 선명한 길잡이,
DTO도 엔티티도 색을 담아 쫙—
프론트엔 반짝 태그색, 여행길이 반짝! 🐇✨

✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/#91-tourspot-tag-add-color

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 42a3681 and 0bc34d6.

📒 Files selected for processing (3)
  • src/main/java/com/opendata/domain/tourspot/dto/TourSpotTagDto.java (1 hunks)
  • src/main/java/com/opendata/domain/tourspot/entity/TourSpotTag.java (1 hunks)
  • src/main/java/com/opendata/domain/tourspot/mapper/TourSpotDetailMapper.java (0 hunks)

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kamillcream kamillcream merged commit 46e6733 into main Sep 16, 2025
0 of 2 checks passed
@kamillcream kamillcream deleted the feat/#91-tourspot-tag-add-color branch September 16, 2025 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] 관광지 태그 속성에 색 추가

2 participants