-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] 마이페이지 api 수정 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough요청 파라미터였던 tourSpotId를 경로 변수로 변경하고, 해당 엔드포인트의 URL 매핑을 업데이트했습니다. 스케줄러를 활성화해 월별 혼잡도 갱신 작업을 매일 03:05 KST에 실행하도록 했습니다. 보안 설정에서 모든 OPTIONS 프리플라이트를 허용하고, 투어스팟 관련 서비스 키 프로퍼티 키를 교체했습니다. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant GW as Spring Security
participant MC as MypageController
Note over C,GW: 경로 변수 기반 엔드포인트
C->>GW: POST /mypage/preferences/{tourspotId}
GW-->>MC: Authenticated request 전달
MC-->>C: 200 OK
C->>GW: DELETE /mypage/preferences/{tourspotId}
GW-->>MC: Authenticated request 전달
MC-->>C: 200 OK
C->>GW: GET /mypage/preferences/check/{tourspotId}
GW-->>MC: Authenticated request 전달
MC-->>C: 200 OK/결과
sequenceDiagram
autonumber
participant B as Browser
participant GW as Spring Security
Note over B,GW: CORS Preflight 처리
B->>GW: OPTIONS /any/path (Preflight)
GW-->>B: 200 OK (permitAll)
sequenceDiagram
autonumber
participant S as Spring Scheduler
participant TS as TourSpotService
Note over S,TS: 매일 03:05 Asia/Seoul
S->>TS: invoke updateMonthlyCongestion()
TS-->>S: 완료
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (5)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📌 PR 개요
✅ 변경사항
🔍 체크리스트
📎 관련 이슈
Closes #83
💬 기타 참고사항
Summary by CodeRabbit