fix(audit): corroborate custom-subject squash merges - #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(#N)associationRoot cause
PR #5 passed all pull-request CI checks because the pull-request event supplied identity evidence.
The subsequent
mainpush failed because its squash merge used a custom--subject, omitting the usual terminal(#5)association. Without pull-request event context, the audit could not associate the otherwise valid GitHub-signed author/committer pair and correctly failed closed.Security boundaries
mainreachability alone is never sufficient(#N)association path remains unchangedREADME
The README is reduced from approximately 15 KB to 9 KB while preserving:
Validation
unverified_platform_claims=0 unknown=0 invalid=0git diff --checkpassed