Fix redundant elimination stateful reads#12
Draft
1sgtpepper wants to merge 5 commits into
Draft
Conversation
Test Results 2 files 2 suites 4m 57s ⏱️ Results for commit 1a6d52b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- preserve global and RAM reads across only matching mutation state\n- distinguish struct member reads by table offset and affine operands\n- add regression coverage and changelog entry\n\n## Testing\n- git diff --cached --check\n- git diff --check\n- git-clang-format --diff upstream/main -- include/llzk/Dialect/Global/IR/Ops.td include/llzk/Transforms/LLZKTransformationPasses.td lib/Transforms/LLZKRedundantOperationEliminationPass.cpp lib/Transforms/LLZKRedundantReadAndWriteEliminationPass.cpp\n- fork CI pending