Open
Conversation
valeryz
reviewed
Dec 18, 2024
Contributor
valeryz
left a comment
valeryz
left a comment
There was a problem hiding this comment.
LGTM, however why does the circuit now support only 4 signers?
|
|
||
| fn main(threshold: pub u8, signers: [PubKey; 10], signatures: [Signature; 10], txn_hash: pub Hash, owners: pub [Address; 10]) { | ||
| verify_signers(threshold, signers, signatures, txn_hash, owners); | ||
| fn main(threshold: pub u8, signers: [PubKey; 4], signatures: [Signature; 4], txn_hash: pub Hash, owners_root: pub Field, indices: [Field; 4], siblings: [[Field; TREE_SIZE]; 4]) { |
Contributor
There was a problem hiding this comment.
why do we have only 4 signers down from 10?
Contributor
|
Hey Khwlid @khemiriwalid, did you have a change to make it work with more than four signers? I guess the problem was too high RAM usage of WASM prover in the newer versions of Noir. Need to either resolve that or roll back to older versions. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.