Repository navigation
Add owned codec writer sessions - #49
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 11 11
Lines 545 545
Branches 25 25
=======================================
Hits 513 513
Misses 29 29
Partials 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Codec::start_owned_writer alongside the borrowed writer API from 0.2.0. Owned sessions accept a boxed Write + Send sink, allowing downstream file objects to store a codec writer without unsafe self-references. Arrow IPC and Parquet share generic writer implementations across borrowed and owned sessions.
This is the missing storage boundary found while integrating resumable writers into fsspec-db. Callers can pass a cloneable shared sink to the writer and retain another handle for draining output.
Type of Change
Checklist