Add support for typescript bit-int types #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: I can't seem to find a logger or default stream setup for writing to stdin, so I just opted for println!(). |
|
This would close |
…t have the time to look into it. However, I hope this helps!
czocher
reviewed
Jul 14, 2023
| println!( | ||
| r#"WARNING: | ||
| 64bit types are not supported by the default JSON lib for JS/TS! This will lead to memory safety issues when passing data between JS/TS and Rust. | ||
| If your intended encpoint is for JSON parsing/serializing between JS/TS & Rust, please consider using a custom JSON parser that supports 64 bit static types. |
There was a problem hiding this comment.
Typo - encpoint should be endpoint I believe?
|
I think testing is going to continue to fail until you remove the big-int-ish types from the list of blocklisted types: https://github.com/1Password/typeshare/blob/main/core/src/rust_types.rs#L257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.