Skip to content

Fix type errors for Luau New Type Solver #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryanlua wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix type errors for Luau New Type Solver #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7dda3
Assert module script type to fix type error
ryanlua Jan 15, 2026
99dde7e
Remove `any` assertion to fix type error
ryanlua Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Features/Themes/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,8 @@ function Themes.set(icon, theme)
Themes.change(icon)
end))
if typeof(theme) == "Instance" and theme:IsA("ModuleScript") then
theme = require(theme)
local themeModule = theme :: ModuleScript
theme = require(themeModule)
end
icon.appliedTheme = theme
Themes.rebuild(icon)
Expand Down Expand Up @@ -350,4 +351,4 @@ end



return Themes
return Themes
4 changes: 2 additions & 2 deletions src/Packages/Janitor.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ function Janitor.__index:Add(Object, MethodName, Index)
end
MethodName = MethodName or TypeDefaults[objectType] or "Destroy"
if type(Object) ~= "function" and not Object[MethodName] then
warn(string.format(METHOD_NOT_FOUND_ERROR, tostring(Object), tostring(MethodName), debug.traceback(nil :: any, 2)))
warn(string.format(METHOD_NOT_FOUND_ERROR, tostring(Object), tostring(MethodName), debug.traceback(nil, 2)))
end

local OriginalTraceback = debug.traceback("")
Expand Down Expand Up @@ -319,4 +319,4 @@ for FunctionName, Function in next, Janitor.__index do
Janitor.__index[NewFunctionName] = Function
end

return Janitor
return Janitor
Loading