LG-10206 Move STEP_INDICATOR_STEP constants out of InPersonFlow #11607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennyverdeyen
commented
Dec 6, 2024
| @@ -83,11 +83,7 @@ def pii_locked? | |||
| end | |||
|
|
|||
| def step_indicator_steps | |||
| if in_person_proofing? | |||
There was a problem hiding this comment.
This was probably just missed in the IPP GPO removal, I did some manual testing and this condition should never be true. There is no longer a need for IPP GPO steps so I updated this block.
gina-yamada
reviewed
Dec 6, 2024
| @@ -60,7 +60,7 @@ def confirm_letter_sends_allowed | |||
|
|
|||
| def step_indicator_steps | |||
| if in_person_proofing? | |||
| Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS_GPO | |||
| Idv::StepIndicatorConcern::STEP_INDICATOR_STEPS_IPP | |||
| else | |||
There was a problem hiding this comment.
I have not tested but I am wondering if this if statement should also be deleted? (Below is resend the letter- I think this is the original send letter)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-10206
🛠 Summary of changes
Moves STEP_INDICATOR_STEPS from InPersonFlow into StepIndicatorConcern. InPersonFlow is FSM-related and will get deleted in a future clean-up PR, so these constants need to be moved as they are still used for the IPP step indicator. References to the old Idv::Flows::InPersonFlow::STEP_INDICATOR_STEPS are updated to reference the new constants.
Note: For 50/50 state management, the old constants in the InPersonFlow are not being removed in this PR.
📜 Testing Plan
No new features or behavior was added - regression testing would be good: