Repository navigation
dates: compare election day by date, not by time of day - #631
Open
arpitjain099 wants to merge 1 commit into
Open
arpitjain099 wants to merge 1 commit into
arpitjain099 wants to merge 1 commit into
Conversation
Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNextElectionDaybuilds its dates at midnight UTC but compares them against the current instant, so from a millisecond past midnight on election day the election already counts as past and the helper jumps to the next cycle. On election day itself, Charlie's home tab tells people the next election day is in 2028 while they are out voting, and a restart that morning schedules the #general-talk reminder for 2028 as well.Comparing at day granularity keeps the whole of election day reading as today. The day after still rolls forward.
The new case sets the clock to 10am eastern on 3 November 2026, which is the default reminder time. It fails on main and passes with the change.
Checklist:
page has been updated if Charlie needs any new OAuth events or scopes
wiki page has been updated if new environment variables were introduced
or existing ones changed