Enable navigation via direct input#1
Open
bradenlc wants to merge 23 commits into17thshard:masterfrom
bradenlc:master
Open
Enable navigation via direct input#1bradenlc wants to merge 23 commits into17thshard:masterfrom bradenlc:master
bradenlc wants to merge 23 commits into17thshard:masterfrom
bradenlc:master
Conversation
added 15 commits
January 30, 2018 19:43
yrsegal
requested changes
Feb 2, 2018
| search.addReaction(jumpRight) | ||
| if (allEmbeds.size > 2) | ||
| search.addReaction(last) | ||
| search.addReaction(nums) |
Member
There was a problem hiding this comment.
This is indented unneccesarially.
|
|
||
| fun updateIndexToInput(originalMessage: Message, entry: Triple<Long, Int, List<EmbedBuilder>>){ | ||
| val questionMessage = originalMessage.channel.sendMessage("What number entry would you like to go to?").get() | ||
| awaiting.add(Pair(Pair(originalMessage,questionMessage),entry)) |
Member
There was a problem hiding this comment.
use to instead of the pair constructor.
yrsegal
requested changes
Feb 2, 2018
| val (messages, entry) = awaitElement | ||
| val (uid, index, embeds) = entry | ||
| if (userInput.author.id == uid) { | ||
| val numsOnly = userInput.content.replace("[^0-9]".toRegex(), "") |
Author
|
Untested post-changes, because I don't have my compiler readily available (am editing online). I wouldn't recommend enacting them yet |
Author
|
Now tested with no conflicts. Edge cases handling as they should. Haven't tested with cross-account interference yet, but I fail to see why that'd break and the rest wouldn't |
yrsegal
approved these changes
Feb 2, 2018
Member
|
Test cross-account interference, just to be safe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.