Remove dependency on rifraf
#1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap to use `fs.promises.rm` with `{ recursive: true, force: true }`,
which should work pretty much identically (just without a 4MB dependency
tree).
Automatic tests pass, but I haven't done anything else to test this yet.
|
This looks great to me. Let’s roll with it as we modernize more of this package for a major version bump in v4.0.0 |
|
Thank you! This will roll up with v4.0.0 of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address 11ty/eleventy/issues/3622
Swap to use
fs.promises.rmwith{ recursive: true, force: true }, which should work pretty much identically (just without a 4MB dependency tree).Automatic tests pass (tested on Node 23), but I haven't done anything else to test this yet. Any ideas?