-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Utiliser PixCode dans le code campagne sur PixApp (PIX-16449). #11397
Open
AndreiaPena
wants to merge
3
commits into
dev
Choose a base branch
from
pix-16449-use-pixcode-for-campaign-code-input
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
6436cdc
to
a1b1a94
Compare
a1b1a94
to
56315ac
Compare
lionelB
reviewed
Feb 12, 2025
|
||
// when | ||
await fillIn('#campaign-code', campaign.code); | ||
await fillIn( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool la mise à jour des sélecteurs en fonction du role 👍
lionelB
approved these changes
Feb 12, 2025
b780f98
to
83187db
Compare
83187db
to
6363e4e
Compare
Base automatically changed from
pix-16448-use-pix-code-on-certification-candidate-entry
to
dev
February 13, 2025 16:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cross-team
Toutes les équipes de dev
👀 Design Review Needed
Func Review OK
PO validated functionally the PR
Tech Review OK
⚠️ PR Inheritance
This PR inherits a first-to-merge PR and will need a rebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Actuellement les champs code sur Pix App ne sont pas des composants Pix UI
🥓 Proposition
Utiliser le nouveau composant PixCode.
😋 Pour tester
Aller sur
/campagnes
dans Pix AppNe pas mettre de code et valider => erreur sous le champ
Mettre un code bidon => message d'erreur
CAS PASSANT :
EVAL12345