Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Utiliser PixCode dans le code campagne sur PixApp (PIX-16449). #11397

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

AndreiaPena
Copy link
Member

@AndreiaPena AndreiaPena commented Feb 11, 2025

🥞 Problème

Actuellement les champs code sur Pix App ne sont pas des composants Pix UI

🥓 Proposition

Utiliser le nouveau composant PixCode.

Capture d’écran 2025-02-11 à 16 43 27

😋 Pour tester

  • Aller sur /campagnes dans Pix App

    • En étant connecté (nom de l'utilisateur dans le titre + message de déconnexion sous le bouton)
    • En étant déconnecté (neutre)
  • Ne pas mettre de code et valider => erreur sous le champ

  • Mettre un code bidon => message d'erreur

  • CAS PASSANT : EVAL12345

@AndreiaPena AndreiaPena added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally team-prescription ⚠️ PR Inheritance This PR inherits a first-to-merge PR and will need a rebase cross-team Toutes les équipes de dev labels Feb 11, 2025
@AndreiaPena AndreiaPena self-assigned this Feb 11, 2025
@AndreiaPena AndreiaPena changed the base branch from dev to pix-16448-use-pix-code-on-certification-candidate-entry February 11, 2025 16:58
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@AndreiaPena AndreiaPena changed the title [FEATURE] Utiliser PixCode dans le code campagne (PIX-16449). [FEATURE] Utiliser PixCode dans le code campagne sur PixApp (PIX-16449). Feb 11, 2025
@AndreiaPena AndreiaPena force-pushed the pix-16449-use-pixcode-for-campaign-code-input branch from 6436cdc to a1b1a94 Compare February 11, 2025 17:15
@AndreiaPena AndreiaPena force-pushed the pix-16449-use-pixcode-for-campaign-code-input branch from a1b1a94 to 56315ac Compare February 11, 2025 18:11

// when
await fillIn('#campaign-code', campaign.code);
await fillIn(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool la mise à jour des sélecteurs en fonction du role 👍

@AndreiaPena AndreiaPena added Tech Review OK Func Review OK PO validated functionally the PR and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally team-prescription labels Feb 12, 2025
@AndreiaPena AndreiaPena force-pushed the pix-16448-use-pix-code-on-certification-candidate-entry branch from b780f98 to 83187db Compare February 12, 2025 14:32
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-16448-use-pix-code-on-certification-candidate-entry branch from 83187db to 6363e4e Compare February 13, 2025 15:58
Base automatically changed from pix-16448-use-pix-code-on-certification-candidate-entry to dev February 13, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cross-team Toutes les équipes de dev 👀 Design Review Needed Func Review OK PO validated functionally the PR Tech Review OK ⚠️ PR Inheritance This PR inherits a first-to-merge PR and will need a rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants