GitHub actions #103
GitHub actions #103
Conversation
demo github action workflow from quickstart guide
add node actions, first tryy
second try, changing workflow so available on this branch, and commenting out pull request event for now
updating gh actions branch# the commit.
indifferentghost
left a comment
indifferentghost
left a comment
There was a problem hiding this comment.
Looks good, but it'd be easier to just do the stuff on merge, more will come to this when I get heroku setup (sorry it's taking so long).
.github/workflows/merge-node.js.yml
Outdated
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
| - name: Build client package | ||
| run: CI='' yarn build --if-present |
There was a problem hiding this comment.
I assume that the CI is used to fix some error?
There was a problem hiding this comment.
https://github.com/100devs/course-tracker/runs/4196173114?check_suite_focus=true
getting errors for warnings because CI=true when this was not set to empty string.
There was a problem hiding this comment.
This is the warnings we want to ensure aren't getting into the codebase. This should be a new issue.
There was a problem hiding this comment.
Removed the CI line from both workflow files (had removed from one only in prev commit to test).
Warnings clean-up is a new issue
…gain with staging branch
…ts yarn.lock to leave in gitignore
Will the staging environment need to be set up once we have heroku? Everything up to that point is ready for review.
Issue #10 setting up Github Actions