Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DEE-1103): added dark theme to feedback web component #882

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

yashoswalyo
Copy link
Contributor

@yashoswalyo yashoswalyo commented Jun 10, 2024

Closes/Fixes/Resolves

Explain the feature/fix

Introduced a dark theme mode for feedback component.

Screencast.from.2024-06-10.18-13-16.webm
Screencast.from.2024-06-10.18-14-13.webm

Does this PR introduce a breaking change

No

Screenshots

View Screenshots

Ready-for-merge Checklist

  • Expected files: all files in this pull request are related to one feature request or issue (no stragglers)?
  • Does the change have appropriate unit tests?
  • Did tests pass?
  • Did you update or add any necessary documentation (README.md, WHY.md, etc.)?
  • My changes generate no new warnings
  • I have performed a self-review of my own code
  • I have documented my code, particularly in areas like todo, complex logic, quick fix, temporary patch, etc.

If it is a new component

  • Does your component follow One Platform style guidelines?
  • Does your component web accessibility standards? Helper Doc
  • Does your component support desktop screen sizes (350px, 720px, 1150px ,1920px)

Browsers you have tested in

  • Latest two versions of Mozilla Firefox and Google Chrome supported by Red Hat Enterprise Linux distribution
  • Google Chrome [Latest 2 versions]
  • Mozilla Firefox [Latest 2 versions]
  • Microsoft Edge [Latest 2 versions]
  • Apple Safari [Latest 2 versions]
  • Microsoft Internet Explorer 11

@yashoswalyo
Copy link
Contributor Author

@hybridx @deshmukhmayur @riginoommen needs review

@yashoswalyo
Copy link
Contributor Author

Tests and Build is passing

image

packages/opc-feedback/package.json Outdated Show resolved Hide resolved
@hybridx hybridx added the enhancement New feature or request label Jun 10, 2024
@hybridx
Copy link
Contributor

hybridx commented Jun 10, 2024

LGTM approved 🎉

@hybridx
Copy link
Contributor

hybridx commented Jun 11, 2024

@yashoswalyo please resolve the conflicts

@yashoswalyo yashoswalyo requested a review from hybridx June 11, 2024 06:32
@hybridx hybridx merged commit 9fc17fc into 1-Platform:master Jun 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants