Skip to content

Commit

Permalink
Added target property for spa and docs button in opc-feedback (#881)
Browse files Browse the repository at this point in the history
* Added target="_blank" for spa and docs button

Added target="_blank" for docs and spa buttons present in opc-feedback so that the docs and feedback page opens in a new tab

* Bumped version to 0.1.2-alpha

* Added contributor name

* updated package-lock

* added target property which by fefault behaves as same but given value as _target will implement only those, Existing users wont be impacted

* Updated documentation

---------

Co-authored-by: Shamsuddin Shamsuddin <[email protected]>
  • Loading branch information
yamalameyooooo and sshamsudRH committed Jun 11, 2024
1 parent 8d2f3c0 commit f13c034
Show file tree
Hide file tree
Showing 4 changed files with 10,180 additions and 6,702 deletions.
3 changes: 3 additions & 0 deletions packages/opc-feedback/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ import '@one-platform/opc-feedback/dist/opc-feedback';
| `summaryLimit` | `Number` value is expected, it is Infinite by default. |
| `app` | `Object` value is expected `{ name: 'one platform', url: '/' }` is the default fallback url for docs |
| `theme` | Refer [themes](https://github.com/1-Platform/op-components/tree/master/packages/opc-feedback/README.md#themes) section. |
| `target` | `String` value is expected, it is `_self` by default. Specifies where to open the linked document Url |

### Default Template

Expand Down Expand Up @@ -241,3 +242,5 @@ npm run test
👤 **Sumeet Ingole**

👤 **Akhil Mohan**

👤 **Shamsuddin**
Loading

0 comments on commit f13c034

Please sign in to comment.