Skip to content

Conversation

@Eittipat
Copy link
Collaborator

Description

Create alternative methods without panic and deprecate old panic methods

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (changes that do NOT affect functionality)
  • Adds or updates testing
  • This change requires a documentation update

@codecov
Copy link

codecov bot commented Oct 11, 2025

Codecov Report

❌ Patch coverage is 52.79188% with 93 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
protobuf/encode.go 57.57% 7 Missing and 7 partials ⚠️
rlp/rlp.go 0.00% 14 Missing ⚠️
protobuf/decode.go 57.89% 4 Missing and 4 partials ⚠️
protobuf/exception_encode.go 42.85% 4 Missing and 4 partials ⚠️
protobuf/utils.go 52.94% 4 Missing and 4 partials ⚠️
rlp/london.go 57.89% 4 Missing and 4 partials ⚠️
rlp/rlp_updateset.go 0.00% 6 Missing ⚠️
db/update_set_encoding.go 33.33% 2 Missing and 2 partials ⚠️
utils/utils.go 73.33% 2 Missing and 2 partials ⚠️
db/substate_db.go 66.66% 3 Missing ⚠️
... and 9 more

❌ Your patch status has failed because the patch coverage (52.79%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Files with missing lines Coverage Δ
substate/account.go 100.00% <100.00%> (ø)
db/destroyed_account_db.go 93.78% <75.00%> (+1.60%) ⬆️
db/update_db.go 87.87% <75.00%> (+0.99%) ⬆️
db/code_db.go 92.30% <50.00%> (-0.83%) ⬇️
db/substate_encoding.go 87.50% <33.33%> (-0.74%) ⬇️
protobuf/updateset.go 80.00% <66.66%> (+80.00%) ⬆️
rlp/rlp_account.go 89.47% <66.66%> (+89.47%) ⬆️
rlp/rlp_message.go 91.11% <60.00%> (-3.01%) ⬇️
rlp/rlp_world_state.go 72.72% <66.66%> (+31.34%) ⬆️
substate/message.go 94.39% <60.00%> (-0.81%) ⬇️
... and 10 more

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Eittipat Eittipat force-pushed the iammop/deprecate-all-panic branch from d433dd8 to 8465d66 Compare October 18, 2025 06:17
@Eittipat Eittipat requested a review from wsodsong October 18, 2025 06:44
@Eittipat Eittipat changed the title Create new methods without panic and deprecate old methods Refactor panic method to return error instead Oct 18, 2025
@Eittipat Eittipat requested a review from cabrador October 18, 2025 06:45
wsodsong
wsodsong previously approved these changes Oct 31, 2025
Copy link
Contributor

@wsodsong wsodsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@wsodsong wsodsong merged commit 56ace78 into main Nov 4, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants