Skip to content

Conversation

@Eittipat
Copy link
Collaborator

Description

Remove RLP related codes from substate repository

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (changes that do NOT affect functionality)

@rpl-ffl
Copy link
Contributor

rpl-ffl commented Mar 31, 2025

Hi @Eittipat,
I understand this must have been discussed before hand, but could you please outline the reason to remove RLP entirely?

rpl-ffl

This comment was marked as spam.

@rpl-ffl rpl-ffl dismissed their stale review March 31, 2025 07:02

Approval meant for another PR

@Eittipat
Copy link
Collaborator Author

@rpl-ffl , This task is assigned by @wsodsong . As I understand, There is no need for RLP code, since we can now moving to protobuf.

However, this pull request should not be merged at this time. We need to wait and see how the rlp-to-protobuf migration process is progressing.

@Eittipat Eittipat force-pushed the iammop/remove-rlp branch from 73bef63 to 18b3d6f Compare April 2, 2025 11:33
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@Eittipat Eittipat force-pushed the iammop/remove-rlp branch 3 times, most recently from 7fa894e to 0f46685 Compare April 9, 2025 01:24
cabrador
cabrador previously approved these changes Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants