Merged
Conversation
psubotic
approved these changes
Jul 1, 2025
aksonic
approved these changes
Jul 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
kmeeth
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes cache dedicated for Strongly Reach operation between two events. As of #24, the frame construction is reduced to a single
stronglyReachableByQuorumoperation and the reprocessing of roots can no longer happen. This means that the necessity of caching the strongly reach operation is greatly reduced, and only possible scenario where it could be helpful is when frame construction and election call the StronglyReach operation back-to-back, with same arguments. This can be eliminated with a simple memoization in future work.Testing done:
All unit tests pass
Client build with the PR branch passes epochs [1, 1100] and [6720, 6970] and produces a correct head.