Skip to content

Fix for the issue with interrupts failing#148

Merged
kmeeth merged 1 commit intomainfrom
kmeeth/fix-for-interrupt-bug
Jun 16, 2025
Merged

Fix for the issue with interrupts failing#148
kmeeth merged 1 commit intomainfrom
kmeeth/fix-for-interrupt-bug

Conversation

@kmeeth
Copy link
Copy Markdown
Contributor

@kmeeth kmeeth commented Jun 16, 2025

We recently discovered an issue where doing a Ctrl+C interrupt on an event import left the database in a state where it could not continue the import process any further. We found that it was linked to the merging of vecfc and vecmt into dagindexer. Namely, sonic used another implementation of vecflushable which was "lost" in the merging. This version is more suitable and seemingly better than the one present in consensus currently, as it addresses the issue at hand.
This recent change causes the issue to stop appearing and imports can be interrupted and resumed normally.

…ith vecmt) that does not have the issue with interrupts.
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
consensus/vecflushable/backed_map.go 70.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@kmeeth kmeeth merged commit 3c45cdd into main Jun 16, 2025
2 of 3 checks passed
@kmeeth kmeeth deleted the kmeeth/fix-for-interrupt-bug branch June 16, 2025 08:41
Tjofil pushed a commit that referenced this pull request Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants