chore: nomenclature change decided -> certified#142
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Tjofil
reviewed
May 5, 2025
kmeeth
reviewed
May 5, 2025
aksonic
force-pushed
the
aksonic/nomenclature-certified
branch
2 times, most recently
from
de580e1 to
1198359
Compare
psubotic
approved these changes
May 5, 2025
Tjofil
reviewed
May 5, 2025
| Q := int32((Q_0 + 3 - 1) / 3) | ||
| yesDecisions := boolMaskInt32Vec(aggregationMatr, func(x int32) bool { return x >= Q }) | ||
| noDecisions := boolMaskInt32Vec(aggregationMatr, func(x int32) bool { return x <= -Q }) | ||
| yesCertifications := boolMaskInt32Vec(aggregationMatr, func(x int32) bool { return x >= Q }) |
Contributor
Contributor
There was a problem hiding this comment.
The method itself can remain certify as it certifies the leader eventually. Other suggestions also welcome.
Contributor
There was a problem hiding this comment.
yes so this is how I will present it leaders are decided but one is certified.
Contributor
There was a problem hiding this comment.
To be fair on Amir I personally only noticed this when doing the slides and our nomenclature table Amir used indicates otherwise, great you brought this up @Tjofil
aksonic
force-pushed
the
aksonic/nomenclature-certified
branch
from
1198359 to
305c436
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please feel free to ignore this PR until it is rebased off of main as this PR is branched off of #140, #141
Verification: