Skip to content

Conversation

@ihtefyw
Copy link
Contributor

@ihtefyw ihtefyw commented Jan 27, 2026

This PR adapts the integration tests in lib.rs to use different DB opening modes.
Moreover, the term mode was used for both live/archive and opening modes. To clarify them, I renamed the DbMode enum to DbOpenMode and the rstest template db_mode to archive_impl_and_open_mode.

Because the open_carmen_db function is used in the FFI DB opening function, I modify it to open the DB always with read/write permissions. I am not sure if it can be of any use to have a read only option from the Go side, but I opened and linked an issue to keep track of it.

@ihtefyw ihtefyw changed the title Use Db opening modes in integration tests + renaming DbMode to DbOpenMode Use Db opening modes in integration tests + rename DbMode to DbOpenMode Jan 27, 2026
@ihtefyw ihtefyw force-pushed the luigi/read-only-db branch from f8b9684 to 8ab5114 Compare January 27, 2026 14:47
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 91.45299% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/src/storage/storage_with_flush_buffer.rs 37.50% 4 Missing and 1 partial ⚠️
rust/src/bin/node_statistics/linear_scan_stats.rs 0.00% 2 Missing ⚠️
rust/src/lib.rs 60.00% 0 Missing and 2 partials ⚠️
...st/src/bin/node_statistics/tree_traversal_stats.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
rust/src/ffi/exported.rs 97.35% <100.00%> (+<0.01%) ⬆️
rust/src/node_manager/cached_node_manager.rs 95.88% <ø> (ø)
rust/src/statistics/storage/mod.rs 96.91% <100.00%> (+1.36%) ⬆️
rust/src/storage/file/file_storage_manager/mod.rs 95.57% <100.00%> (ø)
...storage/file/file_storage_manager/root_ids_file.rs 95.12% <100.00%> (ø)
rust/src/storage/file/from_to_file.rs 90.56% <100.00%> (ø)
rust/src/storage/file/node_file_storage/mod.rs 93.37% <100.00%> (ø)
.../storage/file/node_file_storage/reuse_list_file.rs 97.23% <100.00%> (ø)
rust/src/storage/mod.rs 100.00% <100.00%> (ø)
...st/src/bin/node_statistics/tree_traversal_stats.rs 0.00% <0.00%> (ø)
... and 3 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

psalz
psalz previously approved these changes Jan 28, 2026
@ihtefyw ihtefyw merged commit 17cd78d into main Jan 28, 2026
13 checks passed
@ihtefyw ihtefyw deleted the luigi/read-only-db branch January 28, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants