Use Db opening modes in integration tests + rename DbMode to DbOpenMode #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the integration tests in
lib.rsto use different DB opening modes.Moreover, the term
modewas used for both live/archive and opening modes. To clarify them, I renamed theDbModeenum toDbOpenModeand the rstest templatedb_modetoarchive_impl_and_open_mode.Because the
open_carmen_dbfunction is used in the FFI DB opening function, I modify it to open the DB always with read/write permissions. I am not sure if it can be of any use to have a read only option from the Go side, but I opened and linked an issue to keep track of it.