Skip to content

Conversation

@rpl-ffl
Copy link
Contributor

@rpl-ffl rpl-ffl commented Jun 9, 2025

In block_progress_tracker_test.go, there is a test that checks if each record goes into log as configured.
The test contains

log.EXPECT().Noticef(substateProgressTrackerReportFormat,
6, uint64(1234), int64(11),
executor.MatchRate(gomock.All(executor.Gt(3), executor.Lt(5)), "blkRate"),
executor.MatchRate(gomock.All(executor.Gt(7), executor.Lt(9)), "txRate"),
executor.MatchRate(gomock.All(executor.Gt(700), executor.Lt(900)), "gasRate"),
executor.MatchRate(gomock.All(executor.Gt(3), executor.Lt(5)), "blkRate"),
executor.MatchRate(gomock.All(executor.Gt(7), executor.Lt(9)), "txRate"),
executor.MatchRate(gomock.All(executor.Gt(700), executor.Lt(900)), "gasRate"),
),

which checks the corresponding value that happened during mocking. This is tangentially relevant to the test.

Given that this has caused sporadic issue during testing, the range is now relaxed so that any reasonable value should pass.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@rpl-ffl rpl-ffl changed the base branch from main to matej/fix-block-processing-report June 9, 2025 10:38
@rpl-ffl rpl-ffl changed the base branch from matej/fix-block-processing-report to main June 9, 2025 10:38
@rpl-ffl rpl-ffl requested a review from wsodsong June 11, 2025 05:39
@wsodsong wsodsong force-pushed the rapol/bugfix/relax_profiledb branch from 12cfaf0 to 64fca84 Compare October 3, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants