Skip to content

Conversation

SamueleA
Copy link
Contributor

@SamueleA SamueleA commented Jul 10, 2025

Moves various utils, components and types from the connect package to the newly created "commons" package

Copy link

cloudflare-workers-and-pages bot commented Jul 10, 2025

Deploying web-sdk-react-example with  Cloudflare Pages  Cloudflare Pages

Latest commit: 345b78b
Status: ✅  Deploy successful!
Preview URL: https://ae88b8e8.web-sdk-react-example.pages.dev
Branch Preview URL: https://5410-common-package.web-sdk-react-example.pages.dev

View logs

@SamueleA SamueleA marked this pull request as ready for review July 23, 2025 23:12
@SamueleA SamueleA requested review from 0xsequence-bot and a team as code owners July 23, 2025 23:12
@SamueleA SamueleA force-pushed the 5410-common-package branch 2 times, most recently from 0d0ba2b to 95f1378 Compare July 31, 2025 20:10
@@ -0,0 +1,332 @@
# @0xsequence/hooks
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common package uses README from hooks

@corbanbrook
Copy link
Collaborator

As it currently stands i feel like this common package is too broad in scope and it will be growing over time.

It contains react components, contexts, utilities and constants. Some are specific to the connect ecosystem of packages (connect, checkout, wallet-widget), and some could be used more globally in for instance marketplace, builder, or wallet-webapp.

  1. I think we need to create a clear demarcation between what is specific to "connect" and what is globally useful.

  2. i think we need to break up this package into clear responsibilities of behavior. the web-sdk/hooks package is successfully used across many of our projects now because it aheres to this and is agnostic to connect and low on dependencies.

I would propose that we have separate packages for:

  • utilities: globally useful utility functions
  • components: globally useful higher level/complex sharable components (that don't belong in design-system)
  • connect-core: specific logic which is shared amongst connect based packages (this logic was previously just within the connect package -- maybe it should just go back)

@SamueleA SamueleA marked this pull request as draft August 1, 2025 18:15
@SamueleA SamueleA changed the title common package web-sdk-core package Aug 8, 2025
@SamueleA SamueleA force-pushed the 5410-common-package branch from 41e3c30 to 710ece1 Compare August 13, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants