-
Notifications
You must be signed in to change notification settings - Fork 9
web-sdk-core package #470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
web-sdk-core package #470
Conversation
Deploying web-sdk-react-example with
|
Latest commit: |
345b78b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://ae88b8e8.web-sdk-react-example.pages.dev |
Branch Preview URL: | https://5410-common-package.web-sdk-react-example.pages.dev |
packages/checkout/src/views/Checkout/PaymentMethodSelect/PayWithCrypto/index.tsx
Outdated
Show resolved
Hide resolved
0d0ba2b
to
95f1378
Compare
@@ -0,0 +1,332 @@ | |||
# @0xsequence/hooks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Common package uses README from hooks
As it currently stands i feel like this common package is too broad in scope and it will be growing over time. It contains react components, contexts, utilities and constants. Some are specific to the connect ecosystem of packages (connect, checkout, wallet-widget), and some could be used more globally in for instance marketplace, builder, or wallet-webapp.
I would propose that we have separate packages for:
|
41e3c30
to
710ece1
Compare
Moves various utils, components and types from the connect package to the newly created "commons" package