Add support for all ERC20 for balances #1979
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel Unique URL: https://sendapp-gm0lk9njj-0xsend.vercel.app |
- Created token-enrichment-worker (K8s) to replace Vercel cron - Created balance-reconciliation-worker (K8s) for drift detection - Removed all Vercel cronjobs from vercel.json - Deleted unused API endpoints (enrich-token-data, discover-tokens, bootstrap-balances) - Removed SQL functions: get_undiscovered_tokens, recalculate_erc20_balances - Removed drift thresholds - now reconciles ANY discrepancy - Updated documentation for K8s-first architecture 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| coingeckoApiKey: process.env.COINGECKO_API_KEY, | ||
| } | ||
|
|
||
| logger.info({ config }, 'Starting token enrichment worker') |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 2 months ago
To fix the issue, we must prevent the sensitive value (COINGECKO_API_KEY) from being logged in clear text when outputting the config object with logger.info({ config }, ...).
The best fix is to output a sanitized version of the config object, omitting or redacting the sensitive value.
Therefore:
- Before line 40, create a new object from
configfor logging, with the value ofcoingeckoApiKeyomitted or replaced by a static string such as'<REDACTED>'. - Log the sanitized object in place of
config.
No extra dependencies are needed; this can be achieved with simple object spread/destructuring.
Suggested changeset
1
apps/token-enrichment-worker/src/index.ts
| @@ -37,7 +37,8 @@ | ||
| coingeckoApiKey: process.env.COINGECKO_API_KEY, | ||
| } | ||
|
|
||
| logger.info({ config }, 'Starting token enrichment worker') | ||
| const redactedConfig = { ...config, coingeckoApiKey: config.coingeckoApiKey ? '<REDACTED>' : undefined } | ||
| logger.info({ config: redactedConfig }, 'Starting token enrichment worker') | ||
|
|
||
| // Initialize clients | ||
| const supabase = createClient( |
Copilot is powered by AI and may make mistakes. Always verify output.
Simplified reconciliation system by removing snapshot table: - Removed erc20_balance_snapshots table and view from migration - Removed store_balance_snapshot function - Removed snapshot storage from reconciliation worker - Updated get_balances_to_reconcile to use last reconciliation time - Updated documentation to reflect simpler architecture Rationale: Reconciliation records already capture all necessary data (drift, RPC balance, timestamp). Snapshots for "no drift" cases add storage cost with minimal debugging value. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.