fix(android): expose the detached SSH bridge transport as a per-server option - #336
Open
0xr3ngar wants to merge 1 commit into
Open
fix(android): expose the detached SSH bridge transport as a per-server option#3360xr3ngar wants to merge 1 commit into
0xr3ngar wants to merge 1 commit into
Conversation
…r option The Rust core already implements the detached transport (SshDetachedLauncher, detached_spawn.sh: FIFO stdin + keeper + setsid/nohup, re-attach on reconnect), but DiscoveryScreen.kt hardcoded SshBridgeTransport.EPHEMERAL so it was unreachable. - SavedServer gains a detachedTransport field (persisted, defaults false) - Add Server SSH flow gains a detached-sessions toggle - sshConnectBridgeSession receives DETACHED when the toggle is on - Unit tests: default, JSON round-trip, legacy-missing-field
0xr3ngar
marked this pull request as ready for review
August 28, 2026 02:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335.
SSH bridge sessions were spawned with
SshBridgeTransport.EPHEMERAL(hardcoded inDiscoveryScreen.kt), so agent processes died with the app. The detached transport already exists in the Rust core (SshDetachedLauncher+detached_spawn.sh), so this just adds a per-server "Detached sessions" toggle (default off, behavior unchanged) and passesDETACHEDthrough when enabled. Unit tests included.