fix(ios): clear stale dashboard blur after navigation - #316
Closed
DatScreamer wants to merge 1 commit into
Closed
Conversation
Owner
|
Landed in #319 (merged as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #314
After popping back from a conversation, dashboard session rows can render as opaque gray bars: the row's
pinchBlurUIVisualEffectViewis stuck at full effect because NavigationStack push/pop finishes the pausedUIViewPropertyAnimatorthat drives it. The stale view persists until an external gesture forces a re-layout.Changes:
forceResetPinchBlurIfIdle, cancel any stale fadeCADisplayLinkand remove theUIVisualEffectViewfrom the row hierarchy instead of rebuilding the paused animator. The pinch path lazily reinstalls the view and animator when a real pinch begins.Verification:
make ios(signed package lane), installed on iPhone 17 Pro simulator.