ui: simplify typography and semantic theme defaults [skip mobile-release] - #293
Closed
0xSero wants to merge 2 commits into
Closed
ui: simplify typography and semantic theme defaults [skip mobile-release]#2930xSero wants to merge 2 commits into
0xSero wants to merge 2 commits into
Conversation
Owner
Author
|
Superseded by #295 (v2.0.1 mega convergence). Equivalent mega commits: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2.0.1 Batch UI lane: conversation typography refinement plus semantic theme defaults. Two commits on top of
maina8fb7bfb.Commits
b18cd9c2— chat: refine conversation typography [skip mobile-release] (6 files, +90/−23)conversationCodePointSize), horizontally scrollable code blocks (fixedSizeinstead of max-width squeeze), tightened line/paragraph/block spacing, custom code-block renderer (language header + natural-width scroller).92a66e95— appearance: make Studio the default theme [skip mobile-release] (4 files, +12/−8)codex-light→studio-lightandchatgpt-dark→studio-darkon both platforms, via newdefaultLightThemeSlug/defaultDarkThemeSlug(iOS) andDEFAULT_LIGHT_THEME_SLUG/DEFAULT_DARK_THEME_SLUG(Android) constants.ChatGPT (System)→System UI(3 hunks incl. iOS test);storageValue/raw value stayssystem; persisted preferences unchanged.Supersedes
Supersedes #276 and #277. Do not auto-close — #276/#277 will be manually closed only after this batch merges.
Verification
xcodebuild test -only-testing, iPhone 17 Pro simulator): 13 tests, 0 failures —LitterAppearanceModeTests(3),ThemeDefinitionTests(3),ConversationDisplayPreferenceTests(7).studio-light(accent#0d0d0d, bg#ffffff) +studio-dark(accent#ffffff, bg#181818), matchingstudio-light.json/studio-dark.json.selectedLightTheme=kitty-litter-light/selectedDarkTheme=kitty-litter-darksurvive reinstall and are honored (kitty-litter palette resolved, not overwritten by Studio defaults).rg 'codex-light|chatgpt-dark' apps/: only legitimate theme asset/definition references remain; no fallback-default references.13595c36, ghosttya968e120gitlinks unchanged).Residual / follow-up
ConversationDisplayUITestHarnessViewdoes not wiresyncSystemColorScheme, so the harness renders the dark palette regardless of system appearance. Studio-light resolution is proven via the app-group palette; Studio-dark is visually verified. Harness fix is tracked as a 2.0.2 follow-up (not in this PR).