Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fixes related to nightly and alloy #101

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Fixes related to nightly and alloy #101

merged 2 commits into from
Jun 17, 2024

Conversation

LindaGuiga
Copy link
Contributor

This PR introduces two fixes:

  • Latest nightly made env::set_var unsafe, so this PR introduces an unsafe block when calling the method.
  • It seems that the alloy library changed the second argument in get_block from a bool to a BlockTransactionKind (after updating rust, I got an error message complaining about the type of that argument), so this PR changes the const accordingly.

Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the type change from alloy isn't due to nightly but to a bump in the deps. We should probably pin a specific commit for version control, so that we only upgrade at will, at least until the crates get published.

rpc/src/lib.rs Outdated Show resolved Hide resolved
@Nashtare Nashtare added this to the Cleanups and Misc. milestone Jun 12, 2024
@atanmarko atanmarko force-pushed the fix-nightly-changes branch from 41866ab to 5100fee Compare June 17, 2024 09:10
@atanmarko
Copy link
Member

@Nashtare @LindaGuiga Regression tested with Jerigon, seems all good.

@atanmarko atanmarko requested a review from Nashtare June 17, 2024 09:50
@atanmarko atanmarko force-pushed the fix-nightly-changes branch from 66e9173 to 4a16c21 Compare June 17, 2024 10:02
@atanmarko
Copy link
Member

Note: #[allow(unused_unsafe)] was added in order not to break clippy before latest nightly(1.81.0-nightly). We will remove it when it becomes redundant.

@atanmarko atanmarko merged commit 84eefaa into develop Jun 17, 2024
5 checks passed
@atanmarko atanmarko deleted the fix-nightly-changes branch June 17, 2024 10:51
@Nashtare
Copy link
Collaborator

Note that the PR has been merged without addressing this:

Note that the type change from alloy isn't due to nightly but to a bump in the deps. We should probably pin a specific commit for version control

which is what caused the build to break in the first place.

@atanmarko
Copy link
Member

atanmarko commented Jun 17, 2024

@Nashtare My bad. I'll open another ticket to fix alloy versions. I could do that after we test and merge #81 ?

@Nashtare
Copy link
Collaborator

Yeah sure.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants