perf(protocol): optimize AccountCode equality comparison#2725
Open
giwaov wants to merge 1 commit into0xMiden:nextfrom
Open
perf(protocol): optimize AccountCode equality comparison#2725giwaov wants to merge 1 commit into0xMiden:nextfrom
giwaov wants to merge 1 commit into0xMiden:nextfrom
Conversation
Compare AccountCode instances by commitment and procedures instead of comparing the full MastForest. Two AccountCode instances with identical procedure sets will always have identical commitments, so comparing the MastForest is redundant and expensive. Closes 0xMiden#2429
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize the
PartialEqimplementation forAccountCodeby comparingcommitmentandproceduresinstead of the fullMastForest.Rationale
The existing implementation compares the entire
MastForest(which can be large and expensive to compare) alongside the procedures list. Since thecommitmentis a sequential hash of all procedure MAST roots, twoAccountCodeinstances with identical commitments and procedures are guaranteed to represent the same account interface. Comparing theMastForestis therefore redundant.This resolves the TODO comment that was already in the code suggesting this change.
Changes
crates/miden-protocol/src/account/code/mod.rs:PartialEqto compareself.commitmentandself.proceduresinstead ofself.mastandself.proceduresTest plan
cargo check -p miden-protocolpassescargo clippy -p miden-protocol -- -D warningspassesEqimpl is unchanged and still derived from the updatedPartialEqOrdimpl already compares bycommitmentonly, so ordering and equality are now alignedCloses #2429