fix(docs): correct build_recipient advice map signature#2720
Open
giwaov wants to merge 1 commit into0xMiden:nextfrom
Open
fix(docs): correct build_recipient advice map signature#2720giwaov wants to merge 1 commit into0xMiden:nextfrom
giwaov wants to merge 1 commit into0xMiden:nextfrom
Conversation
Remove STORAGE_COMMITMENT from the declared advice map inputs of build_recipient. The procedure computes the storage commitment itself via compute_storage_commitment and inserts it into the advice map via adv.insert_mem, so callers do not need to supply it. Closes 0xMiden#2693
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The doc comment for \�uild_recipient\ in
ote.masm\ incorrectly listed \STORAGE_COMMITMENT: [INPUTS]\ as a required advice map input. However, the procedure computes the storage commitment itself via \compute_storage_commitment\ and inserts it into the advice map via \�dv.insert_mem, so callers do not need to supply it.
This removes the incorrect advice map input from the declared signature, matching the corrected signature confirmed by @PhilippGackstatter in the issue discussion.
Closes #2693