Conversation
* refactor: fix minor formatting issues * fix: cleanup unecessary stack comments * fix: add newline
…#2676) * refactor: fix minor formatting issues * fix: cleanup unecessary stack comments * fix: add newline * Initial plan * refactor: rename U256[0]/U256[1] to U256_LO/U256_HI in Agglayer MASM comments Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Agent-Logs-Url: https://github.com/0xMiden/protocol/sessions/604803e2-68c0-4ffe-acdd-4926707426f5 * refactor: remove (4) size suffix from AMOUNT_U256_LO/HI in bridge_out.masm comments Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Agent-Logs-Url: https://github.com/0xMiden/protocol/sessions/ab585523-16e0-40fd-b99b-e64a472ef9d0 --------- Co-authored-by: riemann <aleqvids@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com>
* fix: update stack comment in claim_batch_pipe_double_words * fix: update doc comments & formatting * fix(agglayer): remove pub proc definition from internal procs (#2679) * fix: remove pub proc definition from internal procs * fix: add stack comment & newline
* refactor: B2AGG: optimize stack management, update format, remove unused imports * refactor: CLAIM note: remove unused imports, update code format * refactor: CONFIG_AGG_BRIDGE: update code and formatting, remove unused imports * refactor: UPDATE_GER: remove unused imports, update format * chore: update comments format for agglayer account components --------- Co-authored-by: Marti <marti@miden.team>
mmagician
added
agglayer
* refactor: faucet account: remove unused imports, update comments * refactor: update format of the bridge_config * refactor: update format in bridge_in * refactor: fix addr order in config note inline docs * refactor: update format of the bridge_out * refactor: update format of the leaf_utils, move EthereumAddressFormat to eth_address * chore: small format fixes
* fix: fix incorrect stack comments * fix: rm plan md file * fix: undo incorrect padding drop * fix: update comment
* docs(agglayer): inline permissions into note type sections Move the standalone "Current permissions" table from section 1 into per-note-type "Permissions" sub-sections within section 3, making authorization details easier to find when reading about each note type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs(agglayer): add Protocol Description section with audit TODOs Add a new Section 2 describing the high-level protocol flows (bridge-out, bridge-in, GER lifecycle, faucet registration, administration) with TODO markers linking to audit issue files for identified gaps relative to the Solidity v2 contracts. Renumber subsequent sections accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: add flow diagrams * chore: clarify who monitors L1 --------- Co-authored-by: Claude (Opus) <noreply@anthropic.com>
mmagician
added a commit
that referenced
this pull request
Mar 30, 2026
* refactor(agglayer): fix minor formatting issues (#2675) * refactor: fix minor formatting issues * fix: cleanup unecessary stack comments * fix: add newline * refactor: rename U256[N] to U256_LO/U256_HI in Agglayer MASM comments (#2676) * refactor: fix minor formatting issues * fix: cleanup unecessary stack comments * fix: add newline * Initial plan * refactor: rename U256[0]/U256[1] to U256_LO/U256_HI in Agglayer MASM comments Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Agent-Logs-Url: https://github.com/0xMiden/protocol/sessions/604803e2-68c0-4ffe-acdd-4926707426f5 * refactor: remove (4) size suffix from AMOUNT_U256_LO/HI in bridge_out.masm comments Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> Agent-Logs-Url: https://github.com/0xMiden/protocol/sessions/ab585523-16e0-40fd-b99b-e64a472ef9d0 --------- Co-authored-by: riemann <aleqvids@gmail.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mmagician <8402446+mmagician@users.noreply.github.com> * fix: rm unused procedure (#2680) * fix(agglayer): update doc & stack comments (#2678) * fix: update stack comment in claim_batch_pipe_double_words * fix: update doc comments & formatting * fix(agglayer): remove pub proc definition from internal procs (#2679) * fix: remove pub proc definition from internal procs * fix: add stack comment & newline * AggLayer audit preparation fixes (#2686) * refactor: B2AGG: optimize stack management, update format, remove unused imports * refactor: CLAIM note: remove unused imports, update code format * refactor: CONFIG_AGG_BRIDGE: update code and formatting, remove unused imports * refactor: UPDATE_GER: remove unused imports, update format * chore: update comments format for agglayer account components --------- Co-authored-by: Marti <marti@miden.team> * Agglayer modules format unification (#2694) * refactor: faucet account: remove unused imports, update comments * refactor: update format of the bridge_config * refactor: update format in bridge_in * refactor: fix addr order in config note inline docs * refactor: update format of the bridge_out * refactor: update format of the leaf_utils, move EthereumAddressFormat to eth_address * chore: small format fixes * fix(agglayer): fix incorrect stack comments (#2681) * fix: fix incorrect stack comments * fix: rm plan md file * fix: undo incorrect padding drop * fix: update comment * chore: update AggLayer spec (#2710) * docs(agglayer): inline permissions into note type sections Move the standalone "Current permissions" table from section 1 into per-note-type "Permissions" sub-sections within section 3, making authorization details easier to find when reading about each note type. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * docs(agglayer): add Protocol Description section with audit TODOs Add a new Section 2 describing the high-level protocol flows (bridge-out, bridge-in, GER lifecycle, faucet registration, administration) with TODO markers linking to audit issue files for identified gaps relative to the Solidity v2 contracts. Renumber subsequent sections accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: add flow diagrams * chore: clarify who monitors L1 --------- Co-authored-by: Claude (Opus) <noreply@anthropic.com> --------- Co-authored-by: Alexander John Lee <77119221+partylikeits1983@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: riemann <aleqvids@gmail.com> Co-authored-by: Andrey Khmuro <andrey@polygon.technology> Co-authored-by: Claude (Opus) <noreply@anthropic.com> Co-authored-by: Bobbin Threadbare <43513081+bobbinth@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two more PRs that we should include before merging this into
next: