fix(skills): update Rust SDK skills with Miden Day feedback by Keinberger · Pull Request #36 · 0xMiden/project-template

Keinberger · 2026-03-26T13:08:00Z

Context

During Miden Day (2025-03-17), 11 builders used the agentic template and found incorrect API references, missing patterns, and misleading guidance in the Rust SDK skill files. Issues #28, #29, #30 capture the verified corrections. All changes validated against local source repos on main.

Changes

rust-sdk-pitfalls (#28)

Add 7 new pitfalls (P8-P14): Felt::new() Result type, Value read annotations, NoteType construction, AccountId.prefix() type, Felt conversion limits, note-to-component call boundary, note input immutability
Update P1 with max Felt value warning (p-1 vs u64::MAX)
Update P7 with NoteType::Private requirement for P2ID notes

rust-sdk-patterns (#29)

Rewrite P2ID section: fix Recipient::compute signature (Digest not Word), add Digest no-Copy note, link to miden-bank
Add Asset::new(Word) to asset handling, add alloc requirement to note inputs
Add asset receiving via component methods section with miden-bank links

rust-sdk-testing-patterns (#30)

Fix FungibleAsset import path, faucet total_issuance param, add_output_note builder clarification
Add block numbering, note construction rule, multi-transaction test pattern sections
Add dedicated asset-bearing note example section with NoteAssets + FungibleAsset guidance

Closes #28, closes #29, closes #30

greenhat

Looks good overall. Please check my notes.

greenhat · 2026-04-14T06:52:54Z


+**Constructor**: `Asset::new(word)` creates an Asset from a Word.
+
+See [miden-bank bank-account](../../../../miden-bank/contracts/bank-account/src/lib.rs) for complete asset handling patterns including deposit, withdrawal, and balance tracking.


I don't get the path here. Do we expect an agent to clone miden-bank there?

The same goes for the same paths introduced below.

Yeah the idea is to have agents have access to the miden-bank code, working examples turn out to be incredibly helpful for them. I'll update the path to a Github link.

greenhat · 2026-04-14T07:08:24Z

+**Key details:**
+
+- `Recipient::compute(serial_num: Word, script_digest: Digest, inputs: Vec<Felt>)` — the second parameter is `Digest`, not `Word`.
+- `Digest` does not implement `Copy`. Use `.clone()` when reusing a digest in loops or across calls.


Do we really want to do that much hand-holding in our skills? I mean, if some weak model is incapable of figuring this out, I bet it would fail to build any meaningful solution anyway. SOTA models were capable of fixing it a year ago from the compiler build errors.

Fair enough, removing the padding detail.

greenhat · 2026-04-14T07:18:14Z

-```
+**Key details:**
+
+- `Recipient::compute(serial_num: Word, script_digest: Digest, inputs: Vec<Felt>)` — the second parameter is `Digest`, not `Word`.


Recipient::compute is replaced with note::build_recipient in #37 in this piece of code. I suggest removing this change in favor of #37.

Agreed, removing the entire Recipient::compute section in favor of #37's note::build_recipient.

greenhat · 2026-04-14T07:22:58Z

+
+- `Recipient::compute(serial_num: Word, script_digest: Digest, inputs: Vec<Felt>)` — the second parameter is `Digest`, not `Word`.
+- `Digest` does not implement `Copy`. Use `.clone()` when reusing a digest in loops or across calls.
+- P2ID inputs must be padded to 8 elements: `[suffix, prefix, 0, 0, 0, 0, 0, 0]`.


That is not true with note::build_recipient.

Removing, only applies to the old API.

greenhat · 2026-04-14T07:25:45Z

+- `Recipient::compute(serial_num: Word, script_digest: Digest, inputs: Vec<Felt>)` — the second parameter is `Digest`, not `Word`.
+- `Digest` does not implement `Copy`. Use `.clone()` when reusing a digest in loops or across calls.
+- P2ID inputs must be padded to 8 elements: `[suffix, prefix, 0, 0, 0, 0, 0, 0]`.
+- In host/test code, use `NoteRecipient` (from miden-client) instead of `Recipient` for constructing notes.


We already have NoteRecipient used in code in #37. I would rather not put in skills what can be deduced from the code.

Agreed, the code examples show it.

greenhat · 2026-04-14T08:08:58Z

-Notes receive data via inputs (Vec<Felt>), accessed with `active_note::get_inputs()`:
+Notes receive data via inputs (Vec<Felt>), accessed with `active_note::get_inputs()`.
+
+**Requires alloc**: Since `get_inputs()` returns `Vec<Felt>`, you must have `extern crate alloc;` and `use alloc::vec::Vec;` in your `#![no_std]` contract. See the [no-std setup in any contract](../../../contracts/counter-account/src/lib.rs).


As mentioned above, we should not cater to models that cannot figure this out on their own.

Agreed, removing.

greenhat · 2026-04-14T08:11:42Z


+**NoteType for P2ID**: P2ID output notes created in contract code should use `NoteType::Private` (value 2, see P10). Using `NoteType::Public` triggers an opaque "missing details in advice provider" error at execution time. See [miden-bank withdraw](../../../../miden-bank/contracts/bank-account/src/lib.rs) for the working pattern.
+
+## P8: Felt::new() Returns Result in Contract Code


Not anymore. Now it's in sync with the off-chain API and wraparound.

Got it, removing P8.

greenhat · 2026-04-14T08:12:59Z

+
+**Severity**: Medium -- causes compilation errors
+
+`Value::read()` is generic over `V: From<Word>`, so an explicit type annotation is mandatory. Omitting it causes a type inference error.


No longer relevant for the new account storage API.

Removing P9.

greenhat · 2026-04-14T08:18:04Z

+
+**Severity**: Medium -- causes compilation errors
+
+In contract code (compiler SDK), only `as_u64()` exists for converting Felt to integer. `as_int()` is available in host/test code only. `as_u32()` does not exist. For construction, `Felt::from_u32()` is available.


No longer true with the new Felt API.

Removing P12.

greenhat · 2026-04-14T08:19:33Z

+
+**Severity**: Low -- causes incorrect architecture
+
+Note inputs (`active_note::get_inputs()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.


Suggested change

Note inputs (`active_note::get_inputs()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.

Note inputs (`active_note::note_storage()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.

Okey, keeping P14 with updated active_note::get_storage() wording.

Keinberger · 2026-04-14T13:25:13Z

Looks good overall. Please check my notes.

Hey @greenhat, thanks for the review!

I'll push an updated commit that strips the outdated content. Here's what I'm planning:

Updating:

Replacingmiden-bank relative paths with GitHub links to the tutorials repo
The entire Recipient::compute / P2ID section (superseded by note::build_recipient in Migrate to the client v0.14 #37)
Pitfalls P8, P9, P12 (outdated with the new Felt and storage APIs)
The hand-holding tips (padding details, alloc requirement, Digest Copy)
Raw note storage access pattern

Keeping (unique content not in #37):

P13 (note scripts can't call native_account): still valid
P14 (note inputs immutable): updated wording to use active_note::get_storage()
Testing patterns: multi-transaction flow, block numbering, note construction, asset-bearing notes

I'll also double-check P10 and P11 against v0.14 and remove them if they're no longer relevant.

Thanks!

greenhat

Thank you!

Keinberger added 2 commits March 26, 2026 12:45

fix(skills): update Rust SDK skills with Miden Day feedback

e5fcb48

fix(skills): add dedicated asset-bearing note example section

acbd40a

Keinberger requested a review from greenhat April 8, 2026 16:14

Keinberger mentioned this pull request Apr 8, 2026

Migrate to the client v0.14 #37

Open

4 tasks

greenhat requested changes Apr 14, 2026

View reviewed changes

fix(skills): address review feedback, remove v0.14-outdated content

47f079c

Keinberger requested a review from greenhat April 14, 2026 13:26

greenhat approved these changes Apr 15, 2026

View reviewed changes

greenhat merged commit 700222c into main Apr 15, 2026
3 of 5 checks passed

greenhat deleted the fix/rust-sdk-skills-miden-day-feedback branch April 15, 2026 10:54


		Constructor: `Asset::new(word)` creates an Asset from a Word.

		See [miden-bank bank-account](../../../../miden-bank/contracts/bank-account/src/lib.rs) for complete asset handling patterns including deposit, withdrawal, and balance tracking.


		NoteType for P2ID: P2ID output notes created in contract code should use `NoteType::Private` (value 2, see P10). Using `NoteType::Public` triggers an opaque "missing details in advice provider" error at execution time. See [miden-bank withdraw](../../../../miden-bank/contracts/bank-account/src/lib.rs) for the working pattern.

		## P8: Felt::new() Returns Result in Contract Code


		Severity: Medium -- causes compilation errors

		`Value::read()` is generic over `V: From<Word>`, so an explicit type annotation is mandatory. Omitting it causes a type inference error.


		Severity: Medium -- causes compilation errors

		In contract code (compiler SDK), only `as_u64()` exists for converting Felt to integer. `as_int()` is available in host/test code only. `as_u32()` does not exist. For construction, `Felt::from_u32()` is available.


		Severity: Low -- causes incorrect architecture

		Note inputs (`active_note::get_inputs()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.

	Note inputs (`active_note::get_inputs()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.
	Note inputs (`active_note::note_storage()`) are baked at note creation time and cannot be modified after creation. Design note input layouts carefully before deployment.

Conversation

Keinberger commented Mar 26, 2026

Context

Changes

Uh oh!

greenhat left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keinberger Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Keinberger commented Apr 14, 2026

Uh oh!

greenhat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Keinberger Apr 14, 2026 •

edited

Loading