fix(grpc): expose gRPC status headers for browser gRPC-web clients - #166
Open
kutluhaneth46 wants to merge 2 commits into
Open
kutluhaneth46 wants to merge 2 commits into
kutluhaneth46 wants to merge 2 commits into
Conversation
Without Access-Control-Expose-Headers, browsers hide grpc-status and grpc-message, so a real InvalidArgument looks like a malformed empty 200. Match the RPC node's grpc-web exposure set. Fixes 0xMiden#164.
Compile-time coverage for the Status header constants used by the grpc-web CORS layer so a rename cannot silently drop browser-visible errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser clients could not read
grpc-status/grpc-messagefromtransport.miden.iobecause the CORS layer never setAccess-Control-Expose-Headers. A realInvalidArgumentthen looked like HTTP 200 with an empty body.Changes
grpc-status,grpc-message, andgrpc-status-details-binon the gRPC-web CORS layerCloses #164